From 6e5bfc92642508cd577194a01e1f7b72f6181ec3 Mon Sep 17 00:00:00 2001
From: Jafner <40403594+Jafner@users.noreply.github.com>
Date: Fri, 19 Nov 2021 12:31:22 -0800
Subject: [PATCH] Improve virt install

---
 .../{vbios.rom => vbios_patched.rom}          | Bin 1047040 -> 881664 bytes
 dotfiles_github/install_virtualization.sh     |  26 ++++++++++++++++--
 2 files changed, 24 insertions(+), 2 deletions(-)
 rename dotfiles_github/.virtualization/{vbios.rom => vbios_patched.rom} (84%)

diff --git a/dotfiles_github/.virtualization/vbios.rom b/dotfiles_github/.virtualization/vbios_patched.rom
similarity index 84%
rename from dotfiles_github/.virtualization/vbios.rom
rename to dotfiles_github/.virtualization/vbios_patched.rom
index 1c1e46d3a123efa12c6045d26a68128ecdf86a09..5ab2533d584b4d47884f2dca867dc716c5ff617b 100644
GIT binary patch
delta 49
zcmV~$NfCe`006)l6qG|v<C{_j;I&cAW&i`QJN`bto4~?KB(brRDO4H<=j(bV^i>lC

delta 199
zcmZp8VcPJ;e%UV;gL;N42kV9>5r=(>cZ+^zs9^A$xZ}h%<%}5?o-SIof!|U=@(vyk
z`Fw%$AAs_#eJfA0_>{h$64Do#>9+7HNIs!!f+9%%2T=ZbCvT$(+q#mUAB=hDxY|fD
zg7jByFM#P^y0F|({pxGeiwwQ|2Hckz^S3i<u{Q9xS+TZRv9(#Tw^?ztS#h>makW`-
mFSFutX#2&|_KUUc7hBse_O@RfZNE6%esQ(^;$HTPrwRbyiBJ##

diff --git a/dotfiles_github/install_virtualization.sh b/dotfiles_github/install_virtualization.sh
index b2b91329..ccf19b5b 100755
--- a/dotfiles_github/install_virtualization.sh
+++ b/dotfiles_github/install_virtualization.sh
@@ -1,32 +1,54 @@
 #!/bin/bash
 
+# echo back all commands (for debugging)
 set -x
 
+# install virtualization packages
 sudo pacman -S virt-manager qemu vde2 ebtables dnsmasq bridge-utils openbsd-netcat ovmf
 
+# edit default grub config and apply
 sudo sed -i 's/GRUB_CMDLINE_LINUX_DEFAULT="quiet splash apparmor=1 security=apparmor udev.log_priority=3"/GRUB_CMDLINE_LINUX_DEFAULT="quiet splash apparmor=1 security=apparmor amd_iommu=on iommu=pt udev.log_priority=3"/' /etc/default/grub && \
 sudo grub-mkconfig -o /boot/grub/grub.cfg
 
+# edit libvirtd.conf 
 sudo sed -i 's/#unix_sock_group = "libvirt"/unix_sock_group = "libvirt"/' /etc/libvirt/libvirtd.conf && \
 sudo sed -i 's/#unix_sock_rw_perms = "0770"/unix_sock_rw_perms = "0770"/' /etc/libvirt/libvirtd.conf && \
 sudo bash -c 'echo "log_filters=\"1:qemu\"" >> /etc/libvirt/libvirtd.conf' && \
 sudo bash -c 'echo "log_outputs=\"1:file:/var/log/libvirt/libvirtd.log\"" >> /etc/libvirt/libvirtd.conf' && \
+
+# add self to libvirt group, setup libvirtd systemd unit
 sudo usermod -aG libvirt $USER && \
 sudo systemctl enable libvirtd && \
 sudo systemctl start libvirtd && \
+
+# edit user and group for qemu
 sudo sed -i 's/#user = "root"/user = "joey"/' /etc/libvirt/qemu.conf && \
 sudo sed -i 's/#group = "root"/group = "joey"/' /etc/libvirt/qemu.conf && \
+
+# apply libvirtd changes
 sudo systemctl restart libvirtd
 
-cd .virtualization
-source dump_rom.sh
 
+cd .virtualization
+
+
+# dump gpu vbios
+#source dump_rom.sh
+
+# import patched vbios
+sudo chmod -R 660 vbios_patched.rom
+sudo chown joey:joey vbios_patched.rom
+sudo mkdir -p /usr/share/vbios && sudo cp vbios_patched.rom /usr/share/vbios/vbios.rom
+
+# import vm parameters
 sudo cp ./.virtualization/win10.xml /etc/libvirt/qemu/win10.xml
 sudo chown root:root /etc/libvirt/qemu/win10.xml 
 sudo chmod 600 /etc/libvirt/qemu/win10.xml
 
+# autostart default network
 sudo virsh net-autostart default
 
+# install hooks
 sudo chmod +x start.sh stop.sh qemu
 sudo mkdir -p /etc/libvirt/hooks && sudo cp qemu /etc/libvirt/hooks/qemu
 sudo cp start.sh /bin/start.sh